Re: [PATCH 1/3] drm/amdgpu: set GTT_USWC on reserved VRAM allocations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 05.10.2018 um 23:01 schrieb Marek Olšák:
From: Marek Olšák <marek.olsak@xxxxxxx>

Signed-off-by: Marek Olšák <marek.olsak@xxxxxxx>

VRAM is always accessed USWC, so that doesn't looks like it would have any effect to me.

The rest of the series looks good to me,
Christian.

---
  drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
index 904014dc5915..8e0f47343e0e 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
@@ -241,21 +241,23 @@ int amdgpu_bo_create_reserved(struct amdgpu_device *adev,
  	if (!size) {
  		amdgpu_bo_unref(bo_ptr);
  		return 0;
  	}
memset(&bp, 0, sizeof(bp));
  	bp.size = size;
  	bp.byte_align = align;
  	bp.domain = domain;
  	bp.flags = AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED |
-		AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS;
+		   AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS |
+		   (domain & AMDGPU_GEM_DOMAIN_VRAM ?
+			    AMDGPU_GEM_CREATE_CPU_GTT_USWC : 0);
  	bp.type = ttm_bo_type_kernel;
  	bp.resv = NULL;
if (!*bo_ptr) {
  		r = amdgpu_bo_create(adev, &bp, bo_ptr);
  		if (r) {
  			dev_err(adev->dev, "(%d) failed to allocate kernel bo\n",
  				r);
  			return r;
  		}

_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux