On Wed, Oct 3, 2018 at 11:15 AM Shirish S <shirish.s@xxxxxxx> wrote: > > From: Pratik Vishwakarma <Pratik.Vishwakarma@xxxxxxx> > > [Why] > 1. We never submit IBs to KIQ. > 2. Ring test pass without KIQ's ring also. > 3. By skipping we see an improvement of around 500ms > in the amdgpu's resume time. > > [How] > skip IB tests for KIQ ring type. > > Signed-off-by: Shirish S <shirish.s@xxxxxxx> > Signed-off-by: Pratik Vishwakarma <Pratik.Vishwakarma@xxxxxxx> Reviewed-by: Alex Deucher <alexander.deucher@xxxxxxx> > --- > > This patch is a follow-up to the suggestion given by Alex, > while reviewing the patch: https://patchwork.freedesktop.org/patch/250912/ > > -Shirish S > > drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c > index 47817e0..b8963b7 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c > @@ -354,6 +354,14 @@ int amdgpu_ib_ring_tests(struct amdgpu_device *adev) > if (!ring || !ring->ready) > continue; > > + /* skip IB tests for KIQ in general for the below reasons: > + * 1. We never submit IBs to the KIQ > + * 2. KIQ doesn't use the EOP interrupts, > + * we use some other CP interrupt. > + */ > + if (ring->funcs->type == AMDGPU_RING_TYPE_KIQ) > + continue; > + > /* MM engine need more time */ > if (ring->funcs->type == AMDGPU_RING_TYPE_UVD || > ring->funcs->type == AMDGPU_RING_TYPE_VCE || > -- > 2.7.4 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
