> -----Original Message----- > From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Felix > Kuehling > Sent: Monday, October 1, 2018 3:49 PM > To: Quan, Evan <Evan.Quan@xxxxxxx>; Alex Deucher > <alexdeucher@xxxxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx; Russell, Kent > <Kent.Russell@xxxxxxx> > Cc: Deucher, Alexander <Alexander.Deucher@xxxxxxx> > Subject: Re: [PATCH] drm/amdgpu/vega20: make power profile output more > consistent > > [+Kent] > > This may break the rocm-smi tool, which parses the power profile output. > This was at the request of rocm-smi. Since the current rocm-smi couldn't parse the new format. This makes it more similar to previous asics. Alex > Regards, > Felix > > > On 2018-09-27 09:15 PM, Quan, Evan wrote: > > Reviewed-by: Evan Quan <evan.quan@xxxxxxx> > > > >> -----Original Message----- > >> From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of > >> Alex Deucher > >> Sent: 2018年9月27日 21:46 > >> To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx > >> Cc: Deucher, Alexander <Alexander.Deucher@xxxxxxx> > >> Subject: [PATCH] drm/amdgpu/vega20: make power profile output more > >> consistent > >> > >> Make the profile name line match previous generations more closely. > >> > >> E.g., > >> 0 3D_FULL_SCREEN : > >> vs: > >> 0(3D_FULL_SCREEN ) > >> > >> Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx> > >> --- > >> drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c > >> b/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c > >> index 2a554f9edcda..75945fc50b3a 100644 > >> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c > >> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c > >> @@ -3165,7 +3165,7 @@ static int > vega20_get_power_profile_mode(struct > >> pp_hwmgr *hwmgr, char *buf) > >> "[GetPowerProfile] Failed to get activity > monitor!", > >> return result); > >> > >> - size += sprintf(buf + size, "%2d(%14s%s)\n", > >> + size += sprintf(buf + size, "%2d %14s%s:\n", > >> i, profile_name[i], (i == hwmgr- > >>> power_profile_mode) ? "*" : " "); > >> size += sprintf(buf + size, > >> "%19s %d(%13s) %7d %7d %7d %7d %7d %7d %7d %7d %7d\n", > >> -- > >> 2.13.6 > >> > >> _______________________________________________ > >> amd-gfx mailing list > >> amd-gfx@xxxxxxxxxxxxxxxxxxxxx > >> https://lists.freedesktop.org/mailman/listinfo/amd-gfx > > _______________________________________________ > > amd-gfx mailing list > > amd-gfx@xxxxxxxxxxxxxxxxxxxxx > > https://lists.freedesktop.org/mailman/listinfo/amd-gfx > > _______________________________________________ > amd-gfx mailing list > amd-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
