[PATCH] drm/amd/powerplay: fix compile warning for wrong data type V2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> On Behalf Of Evan
> Quan
> Sent: Wednesday, September 5, 2018 1:19 AM
> To: amd-gfx at lists.freedesktop.org
> Cc: Deucher, Alexander <Alexander.Deucher at amd.com>; Quan, Evan
> <Evan.Quan at amd.com>
> Subject: [PATCH] drm/amd/powerplay: fix compile warning for wrong data
> type V2
> 
> do_div expects the 1st argument in 64bit instead of 32bit.
> Drop the usage of do_div as it seems unnecessary.
> 
> V2: drop usage of do_div completely
> 
> Change-Id: Id2032a43727e7f1fa5163333d3565354d412a561
> Signed-off-by: Evan Quan <evan.quan at amd.com>

Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c
> b/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c
> index 3efd59e984a3..1e65ac01e0f5 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c
> @@ -1195,7 +1195,7 @@ static int vega20_set_sclk_od(
>  	int ret = 0;
> 
>  	od_sclk = golden_sclk_table->dpm_levels[golden_sclk_table->count
> - 1].value * value;
> -	do_div(od_sclk, 100);
> +	od_sclk /= 100;
>  	od_sclk += golden_sclk_table->dpm_levels[golden_sclk_table-
> >count - 1].value;
> 
>  	ret = vega20_od8_set_settings(hwmgr,
> OD8_SETTING_GFXCLK_FMAX, od_sclk); @@ -1242,7 +1242,7 @@ static int
> vega20_set_mclk_od(
>  	int ret = 0;
> 
>  	od_mclk = golden_mclk_table->dpm_levels[golden_mclk_table-
> >count - 1].value * value;
> -	do_div(od_mclk, 100);
> +	od_mclk /= 100;
>  	od_mclk += golden_mclk_table->dpm_levels[golden_mclk_table-
> >count - 1].value;
> 
>  	ret = vega20_od8_set_settings(hwmgr, OD8_SETTING_UCLK_FMAX,
> od_mclk);
> --
> 2.18.0
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx


[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux