[PATCH] drm/amdgpu: remove redundant memset

ckoenig.leichtzumerken@xxxxxxxxx (Christian König) · Wed, 29 Aug 2018 17:15:49 +0200

Am 29.08.2018 um 17:13 schrieb Philip Yang:
> kvmalloc_array uses __GFP_ZERO flag ensures that the returned address
> is zeroed already, memset it to zero again afterwards is unnecessary

and in this case buggy because we only clear the first entry.

>
> Change-Id: If94a59d3cbf2690dd2a1e2add71bc393df6a9686
> Signed-off-by: Philip Yang <Philip.Yang at amd.com>

Reviewed-by: Christian KÃ¶nig <christian.koenig at amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> index 153c9be..33d9ce2 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> @@ -540,7 +540,6 @@ static int amdgpu_vm_alloc_levels(struct amdgpu_device *adev,
>   						   GFP_KERNEL | __GFP_ZERO);
>   		if (!parent->entries)
>   			return -ENOMEM;
> -		memset(parent->entries, 0 , sizeof(struct amdgpu_vm_pt));
>   	}
>   
>   	from = saddr >> shift;