Patches #1-#4 are Reviewed-by: Christian König <christian.koenig at amd.com>
I would squash patches #5-#8 into one and make sure that the patch is a
clean replacement of the existing functionality with the new one.
For example patch #5 still has some code move for the stub fence which
now seems unnecessary.
Regards,
Christian.
Am 24.08.2018 um 14:12 schrieb Chunming Zhou:
> That is certainly totally nonsense. dma_fence_enable_sw_signaling()
> is the function who is calling this callback.
>
> Signed-off-by: Chunming Zhou <david1.zhou at amd.com>
> Cc: Jason Ekstrand <jason at jlekstrand.net>
> Reviewed-by: Christian König <christian.koenig at amd.com>
> Acked-by: Daniel Vetter <daniel at ffwll.ch>
> ---
> drivers/gpu/drm/drm_syncobj.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c
> index 3a8837c49639..d17ed75ac7e2 100644
> --- a/drivers/gpu/drm/drm_syncobj.c
> +++ b/drivers/gpu/drm/drm_syncobj.c
> @@ -184,7 +184,6 @@ static const char *drm_syncobj_null_fence_get_name(struct dma_fence *fence)
>
> static bool drm_syncobj_null_fence_enable_signaling(struct dma_fence *fence)
> {
> - dma_fence_enable_sw_signaling(fence);
> return !dma_fence_is_signaled(fence);
> }
>
