On 2018-08-22 02:55 AM, Christian König wrote:
> Am 21.08.2018 um 23:45 schrieb Felix Kuehling:
[snip]
>> +Â Â Â } else {
>>> +Â Â Â Â Â Â Â struct sysinfo si;
>>> +Â Â Â Â Â Â Â unsigned int phys_ram_gb;
>>> +
>>> +Â Â Â Â Â Â Â /* Optimal VM size depends on the amount of physical
>>> +Â Â Â Â Â Â Â Â * RAM available. Underlying requirements and
>>> +Â Â Â Â Â Â Â Â * assumptions:
>>> +Â Â Â Â Â Â Â Â *
>>> +Â Â Â Â Â Â Â Â *Â - Need to map system memory and VRAM from all GPUs
>>> +Â Â Â Â Â Â Â Â *Â Â Â Â - VRAM from other GPUs not known here
>>> +Â Â Â Â Â Â Â Â *Â Â Â Â - Assume VRAM <= system memory
>>> +Â Â Â Â Â Â Â Â *Â - On GFX8 and older, VM space can be segmented for
>>> +Â Â Â Â Â Â Â Â *Â Â Â different MTYPEs
>>> +Â Â Â Â Â Â Â Â *Â - Need to allow room for fragmentation, guard pages etc.
>>> +Â Â Â Â Â Â Â Â */
>>> +Â Â Â Â Â Â Â si_meminfo(&si);
>>> +Â Â Â Â Â Â Â phys_ram_gb = ((uint64_t)si.totalram * si.mem_unit) >> 30;
>
> Looks good to me, but I would make sure that round that up before
> shifting it.
Hmm, we used to round up. I just removed it because we were told it's
not necessary.
But I guess rounding up to the next power of two increases the available
VM size without increasing page table size. So we should take it if we
can get it for free. I'll reintroduce rounding up.
>
>>> +Â Â Â Â Â Â Â vm_size = min(max(phys_ram_gb * 3, min_vm_size), max_size);
>
> Mhm, "phys_ram_gb * 3"? Maybe add a comment with the rational for that.
Well, the long comment above was meant to justify the factor 3. Maybe I
didn't make that clear enough. 1x is system memory itself, 2x is a wild
guess of VRAM on all GPUs. 3x is room for a second aperture for MTYPE
control, fragmentation and guard pages.
Regards,
 Felix
>
> Christian.
>
>>> Â Â Â Â Â }
>>> Â Â Â Â Â Â adev->vm_manager.max_pfn = (uint64_t)vm_size << 18;
>>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h
>>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h
>>> index 1162c2b..ab1d23e 100644
>>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h
>>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h
>>> @@ -345,7 +345,7 @@ struct amdgpu_bo_va_mapping
>>> *amdgpu_vm_bo_lookup_mapping(struct amdgpu_vm *vm,
>>> Â void amdgpu_vm_bo_trace_cs(struct amdgpu_vm *vm, struct
>>> ww_acquire_ctx *ticket);
>>> Â void amdgpu_vm_bo_rmv(struct amdgpu_device *adev,
>>> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â struct amdgpu_bo_va *bo_va);
>>> -void amdgpu_vm_adjust_size(struct amdgpu_device *adev, uint32_t
>>> vm_size,
>>> +void amdgpu_vm_adjust_size(struct amdgpu_device *adev, uint32_t
>>> min_vm_size,
>>> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â uint32_t fragment_size_default, unsigned max_level,
>>> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â unsigned max_bits);
>>> Â int amdgpu_vm_ioctl(struct drm_device *dev, void *data, struct
>>> drm_file *filp);
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
>
