On 08/14/2018 05:58 PM, Michel Dänzer wrote:
> From: Michel Dänzer <michel.daenzer at amd.com>
>
> The compiler points out that an int doesn't work as intended if
> dev->bo_handles.max_key > INT_MAX:
>
> ../../amdgpu/amdgpu_bo.c: In function â??amdgpu_find_bo_by_cpu_mappingâ??:
> ../../amdgpu/amdgpu_bo.c:550:16: warning: comparison of integer expressions of different signedness: â??intâ?? and â??uint32_tâ?? {aka â??unsigned intâ??} [-Wsign-compare]
> for (i = 0; i < dev->bo_handles.max_key; i++) {
> ^
> ../../amdgpu/amdgpu_bo.c:558:8: warning: comparison of integer expressions of different signedness: â??intâ?? and â??uint32_tâ?? {aka â??unsigned intâ??} [-Wsign-compare]
> if (i < dev->bo_handles.max_key) {
> ^
>
> Fixes: 4d454424e1f2 ("amdgpu: add a function to find bo by cpu mapping
> (v2)")
> Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>
Thanks.
Reviewed-by: Junwei Zhang <Jerry.Zhang at amd.com>
> ---
> amdgpu/amdgpu_bo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/amdgpu/amdgpu_bo.c b/amdgpu/amdgpu_bo.c
> index b790e9be..86d1c143 100644
> --- a/amdgpu/amdgpu_bo.c
> +++ b/amdgpu/amdgpu_bo.c
> @@ -535,7 +535,7 @@ int amdgpu_find_bo_by_cpu_mapping(amdgpu_device_handle dev,
> amdgpu_bo_handle *buf_handle,
> uint64_t *offset_in_bo)
> {
> - int i;
> + uint32_t i;
> struct amdgpu_bo *bo;
>
> if (cpu == NULL || size == 0)
>
