Dear Felix, dear Yong, On 07/13/18 22:17, Felix Kühling wrote: > From: Yong Zhao <Yong.Zhao at amd.com> > > Add DID and kfd_device_info for Raven. > > Signed-off-by: Yong Zhao <Yong.Zhao at amd.com> > Reviewed-by: Felix Kuehling <Felix.Kuehling at amd.com> > Signed-off-by: Felix Kuehling <Felix.Kuehling at amd.com> > Acked-by: Alex Deucher <alexander.deucher at amd.com> > --- > drivers/gpu/drm/amd/amdkfd/kfd_device.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c b/drivers/gpu/drm/amd/amdkfd/kfd_device.c > index 572235c..1b04871 100644 > --- a/drivers/gpu/drm/amd/amdkfd/kfd_device.c > +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device.c > @@ -70,6 +70,21 @@ static const struct kfd_device_info carrizo_device_info = { > .needs_pci_atomics = false, > .num_sdma_engines = 2, > }; > + > +static const struct kfd_device_info raven_device_info = { > + .asic_family = CHIP_RAVEN, > + .max_pasid_bits = 16, > + .max_no_of_hqd = 24, > + .doorbell_size = 8, > + .ih_ring_entry_size = 8 * sizeof(uint32_t), > + .event_interrupt_class = &event_interrupt_class_v9, > + .num_of_watch_points = 4, > + .mqd_size_aligned = MQD_SIZE_ALIGNED, > + .supports_cwsr = true, > + .needs_iommu_device = true, > + .needs_pci_atomics = true, > + .num_sdma_engines = 1, > +}; > #endif > > static const struct kfd_device_info hawaii_device_info = { > @@ -259,6 +274,7 @@ static const struct kfd_deviceid supported_devices[] = { > { 0x9875, &carrizo_device_info }, /* Carrizo */ > { 0x9876, &carrizo_device_info }, /* Carrizo */ > { 0x9877, &carrizo_device_info }, /* Carrizo */ > + { 0x15DD, &raven_device_info }, /* Raven */ > #endif > { 0x67A0, &hawaii_device_info }, /* Hawaii */ > { 0x67A1, &hawaii_device_info }, /* Hawaii */ I built the branch *amdkfd-next* from [1], but on the MIS B350M MORTAR (MS-7A37) with BIOS 1.G1 05/17/2018 it is not loaded. ``` $ uname -a Linux tokeiihto 4.18.0-rc3-01368-gb5aa3f4aef72 #51 SMP Mon Jul 30 13:11:36 UTC 2018 x86_64 GNU/Linux $ grep HSA /boot/config-4.18.0-rc3-01368-gb5aa3f4aef72 CONFIG_HSA_AMD=m $ sudo dmesg | grep -i kfd [ 23.206628] calling kfd_module_init+0x0/0x1000 [amdkfd] @ 365 [ 23.209082] kfd kfd: Initialized module [ 23.209667] initcall kfd_module_init+0x0/0x1000 [amdkfd] returned 0 after 2960 usecs [ 23.212852] kfd kfd: DID 15dd is missing in supported_devices [ 23.212856] kfd kfd: kgd2kfd_probe failed $ /sbin/modinfo amdkfd filename: /lib/modules/4.18.0-rc3-01368-gb5aa3f4aef72/kernel/drivers/gpu/drm/amd/amdkfd/amdkfd.ko version: 0.7.2 license: GPL and additional rights description: Standalone HSA driver for AMD's GPUs author: AMD Inc. and others srcversion: 9AAD0B6E4510ACF8D20A888 depends: retpoline: Y intree: Y name: amdkfd vermagic: 4.18.0-rc3-01368-gb5aa3f4aef72 SMP mod_unload sig_id: PKCS#7 [�] ``` Any hints, what I am doing wrong? Kind regards, Paul PS: Output of lspci: ``` $ lspci -nn 00:00.0 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Device [1022:15d0] 00:00.2 IOMMU [0806]: Advanced Micro Devices, Inc. [AMD] Device [1022:15d1] 00:01.0 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Family 17h (Models 00h-0fh) PCIe Dummy Host Bridge [1022:1452] 00:01.2 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD] Device [1022:15d3] 00:08.0 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Family 17h (Models 00h-0fh) PCIe Dummy Host Bridge [1022:1452] 00:08.1 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD] Device [1022:15db] 00:08.2 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD] Device [1022:15dc] 00:14.0 SMBus [0c05]: Advanced Micro Devices, Inc. [AMD] FCH SMBus Controller [1022:790b] (rev 61) 00:14.3 ISA bridge [0601]: Advanced Micro Devices, Inc. [AMD] FCH LPC Bridge [1022:790e] (rev 51) 00:18.0 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Device [1022:15e8] 00:18.1 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Device [1022:15e9] 00:18.2 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Device [1022:15ea] 00:18.3 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Device [1022:15eb] 00:18.4 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Device [1022:15ec] 00:18.5 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Device [1022:15ed] 00:18.6 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Device [1022:15ee] 00:18.7 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Device [1022:15ef] 15:00.0 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD] 300 Series Chipset USB 3.1 xHCI Controller [1022:43bb] (rev 02) 15:00.1 SATA controller [0106]: Advanced Micro Devices, Inc. [AMD] 300 Series Chipset SATA Controller [1022:43b7] (rev 02) 15:00.2 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD] Device [1022:43b2] (rev 02) 16:00.0 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD] 300 Series Chipset PCIe Port [1022:43b4] (rev 02) 16:01.0 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD] 300 Series Chipset PCIe Port [1022:43b4] (rev 02) 16:04.0 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD] 300 Series Chipset PCIe Port [1022:43b4] (rev 02) 18:00.0 Ethernet controller [0200]: Realtek Semiconductor Co., Ltd. RTL8111/8168/8411 PCI Express Gigabit Ethernet Controller [10ec:8168] (rev 15) 38:00.0 VGA compatible controller [0300]: Advanced Micro Devices, Inc. [AMD/ATI] Raven Ridge [Radeon Vega Series / Radeon Vega Mobile Series] [1002:15dd] (rev c8) 38:00.1 Audio device [0403]: Advanced Micro Devices, Inc. [AMD/ATI] Device [1002:15de] 38:00.2 Encryption controller [1080]: Advanced Micro Devices, Inc. [AMD] Device [1022:15df] 38:00.3 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD] Device [1022:15e0] 38:00.4 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD] Device [1022:15e1] 38:00.6 Audio device [0403]: Advanced Micro Devices, Inc. [AMD] Device [1022:15e3] 39:00.0 SATA controller [0106]: Advanced Micro Devices, Inc. [AMD] FCH SATA Controller [AHCI mode] [1022:7901] (rev 61) ``` [1]: git://people.freedesktop.org/~gabbayo/linux.git -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/pkcs7-signature Size: 5174 bytes Desc: S/MIME Cryptographic Signature URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20180730/31f0b5a3/attachment-0001.bin>