On Fri, Jul 27, 2018 at 02:49:39PM +0800, Koenig, Christian wrote: > Am 27.07.2018 um 08:56 schrieb Huang Rui: > > On Thu, Jul 26, 2018 at 02:41:17PM +0800, Christian König wrote: > >> Am 26.07.2018 um 08:11 schrieb Huang Rui: > >>> This patch cleans up spaces and algin the text to refine the comment for > >>> amdgpu_ttm. > >>> > >>> Signed-off-by: Huang Rui <ray.huang at amd.com> > >> Yeah, that was also on my TODO list for a while. > > My pleasure if I can help you do something. > > > >> Patch is Reviewed-by: Christian König <christian.koenig at amd.com>, but > >> please make sure that the result of "make htmldocs" now looks like it > >> should. > > preparing documents... done > > WARNING: dvipng command 'dvipng' cannot be run (needed for math display), > > check the pngmath_dvipng setting > > writing output... [100%] vm/zswap > > generating indices... genindex > > writing additional pages... search > > copying images... [100%] media/uapi/v4l/vbi_525.svg > > copying static files... done > > copying extra files... done > > dumping search index in English (code: en) ... done > > dumping object inventory... done > > build succeeded, 77 warnings. > > > > I built "make htmldocs", it seems succefully. Then use browser to access > > below path, right? > > > > SPHINX htmldocs --> file:///home/ray/linux/Documentation/output > > > > If yes, it's strange I cannot see anything from the browser. > > Your approach sounds correct to me, could be that this file is not even > pulled into the HTML documentation yet. Yes, I can see the HTML documentation, but amdgpu_ttm.c isn't added. > > Anyway your cleanup is valid, so we can look at this later on. > OK. Thanks, Ray
