On 07/26/2018 07:07 PM, Christian König wrote: > Am 26.07.2018 um 12:02 schrieb Junwei Zhang: >> pass the evict flag instead of hard code >> >> Signed-off-by: Junwei Zhang <Jerry.Zhang at amd.com> > > I can't come up with a reason why we shouldn't do this, but please test suspend/resume with this change just to be extra sure. Yes, already done test for S3 Regards, Jerry > > Apart from that patch is Reviewed-by: Christian König <christian.koenig at amd.com>. > > Regards, > Christian > >> --- >> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c >> index 8c4358e..c1ae528 100644 >> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c >> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c >> @@ -580,7 +580,7 @@ static int amdgpu_move_vram_ram(struct ttm_buffer_object *bo, bool evict, >> } >> /* blit VRAM to GTT */ >> - r = amdgpu_move_blit(bo, true, ctx->no_wait_gpu, &tmp_mem, old_mem); >> + r = amdgpu_move_blit(bo, evict, ctx->no_wait_gpu, &tmp_mem, old_mem); >> if (unlikely(r)) { >> goto out_cleanup; >> } >> @@ -632,7 +632,7 @@ static int amdgpu_move_ram_vram(struct ttm_buffer_object *bo, bool evict, >> } >> /* copy to VRAM */ >> - r = amdgpu_move_blit(bo, true, ctx->no_wait_gpu, new_mem, old_mem); >> + r = amdgpu_move_blit(bo, evict, ctx->no_wait_gpu, new_mem, old_mem); >> if (unlikely(r)) { >> goto out_cleanup; >> } >