On 2018å¹´07æ??25æ?¥ 13:28, Takashi Iwai wrote: > On Wed, 25 Jul 2018 05:32:52 +0200, > Qu, Jim wrote: >> @@ -269,6 +271,10 @@ static void radeon_audio_enable(struct radeon_device *rdev, >> >> if (rdev->audio.funcs->enable) >> rdev->audio.funcs->enable(rdev, pin, enable_mask); >> + >> + if (acomp && acomp->audio_ops && acomp->audio_ops->pin_eld_notify) >> + acomp->audio_ops->pin_eld_notify(acomp->audio_ops->audio_ptr, >> + pin->id, -1); >> >> Jim: radeon_audio_enable() can enable audios and also disable them, so eld noitfy callback should be called when enable_mask is true. > It's intentional. The notifier needs to be called at disablement > time, too. The audio driver has to follow the HDMI audio disablement, > and notifier receives both on and off case. > > The actual state is inquired via get_eld call by HD-audio followed > after the notification. > > > thanks, > > Takashi OK, I got your point. Thanks JimQu
