On 2018-07-23 12:06 PM, Shirish S wrote: > This patch moves amdgpu_fbdev_set_suspend() to the beginning > of suspend sequence. Would be nice to have some rationale, e.g.: This is to avoid fbcon trying to write to the GPU's memory when the GPU is already powered down. Other than that looks great, thanks. With a rationale added to the commit log, Reviewed-by: Michel Dänzer <michel.daenzer at amd.com> -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer