Sure Michel, but not immediately. Is that fine? Regards, Shirish S -----Original Message----- From: Michel Dänzer [mailto:michel@xxxxxxxxxxx] Sent: Friday, July 20, 2018 1:04 PM To: S, Shirish <Shirish.S at amd.com> Cc: amd-gfx at lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: lock and unlock console only for amdgpu_fbdev_set_suspend [V2] On 2018-07-19 11:20 AM, Michel Dänzer wrote: > > Possible follow-up work: > > * Move the console_(un)lock calls into amdgpu_fbdev_set_suspend, or > maybe use drm_fb_helper_set_suspend_unlocked instead of locking > ourselves > > * Move the amdgpu_fbdev_set_suspend call in amdgpu_device_suspend > further up, at least before the pci_set_power_state call. Shirish, would you like to look into these? -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer