On 2018-07-19 12:02 PM, Shirish S wrote: > [Why] > While the console_lock is held, console output will be buffered, till > its unlocked it wont be emitted, hence its ideal to unlock sooner to enable > debugging/detecting/fixing of any issue in the remaining sequence of events > in resume path. > The concern here is about consoles other than fbcon on the device, > e.g. a serial console > > [How] > This patch restructures the console_lock, console_unlock around > amdgpu_fbdev_set_suspend() and moves this new block appropriately. > > V2: Kept amdgpu_fbdev_set_suspend after pci_set_power_state > V3: Updated the commit message to clarify the real concern that this patch > addresses. > V4: code clean-up. > V5: fixed return value > > Signed-off-by: Shirish S <shirish.s at amd.com> > Reviewed-by: Michel Dänzer <michel.daenzer at amd.com> In the future, please mark which revision a review was given for when making significant changes in later revisions. However, v5 looks good, so in this case, you can leave it as is. :) (BTW, this is also a bug fix: we would leave the console locked if amdgpu_amdkfd_resume returned an error) -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer
