On 2018-07-19 11:29 AM, Shirish S wrote: > [Why] > While the console_lock is held, console output will be buffered, till > its unlocked it wont be emitted, hence its ideal to unlock sooner to enable > debugging/detecting/fixing of any issue in the remaining sequence of events > in resume path. > The concern here is about consoles other than fbcon on the device, > e.g. a serial console > > [How] > This patch restructures the console_lock, console_unlock around > amdgpu_fbdev_set_suspend() and moves this new block appropriately. > > V2: Kept amdgpu_fbdev_set_suspend after pci_set_power_state > V3: Updated the commit message to clarify the real concern that this patch > addresses. > Signed-off-by: Shirish S <shirish.s at amd.com> > Reviewed-by: Michel Dänzer <michel.daenzer at amd.com> > > [...] > > drm_kms_helper_poll_enable(dev); > @@ -2808,13 +2808,7 @@ int amdgpu_device_resume(struct drm_device *dev, bool resume, bool fbcon) > dev->dev->power.disable_depth--; > #endif > > - if (fbcon) > - amdgpu_fbdev_set_suspend(adev, 0); > - > unlock: > - if (fbcon) > - console_unlock(); > - > return r; > } > > Oh, please remove the now useless unlock label as well. Sorry I missed that before. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer
