On 2018-07-17 08:14 PM, Marek Olšák wrote: > Michel, I think you are wasting your time. This change can be misused > as easily as any other API. It's not more dangerous that any other > amdgpu libdrm function. That's trivially false. > You won't achieve anything by optimizing the hash table (= losing time), > [...] I think you're focusing too much on your immediate desire instead of the big(ger) picture. E.g. I see amdgpu_bo_export getting called from surprising places (in Xorg), performing a hash table lookup each time. Fixing that would achieve something, though probably not much. Anyway, adding dangerous API (keep in mind that we don't control all libdrm_amdgpu users, or even know how they're using it) for something that can also be achieved without is just a bad idea. Avoiding that is achievement enough. This is my opinion. I don't have veto power over libdrm_amdgpu. At least Christian seems in favour of this change. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer
