Hi Michel, Could randrproto >= 1.6.0 also be optional? randrproto 1.6 is pretty new so most old xserver doesn't compile with it. When compile latest ddx with various OS we support, it will fail. Maybe we can define RR_PROPERTY_NON_DESKTOP in ddx if not yet. Regards, Qiang ________________________________________ From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> on behalf of Michel Dänzer <michel at daenzer.net> Sent: Tuesday, July 10, 2018 12:20:46 AM To: Keith Packard Cc: amd-gfx at lists.freedesktop.org Subject: Re: [PATCH xf86-video-amdgpu 1/3] modesetting: Record non-desktop kernel property at PreInit time On 2018-07-09 06:14 PM, Keith Packard wrote: > Michel Dänzer <michel at daenzer.net> writes: > >> From: Keith Packard <keithp at keithp.com> >> >> Save any value of the kernel non-desktop property in the xf86Output >> structure to avoid non-desktop outputs in the default configuration. >> >> [Also bump randrproto requirement to a version that defines >> RR_PROPERTY_NON_DESKTOP - ajax] >> >> Signed-off-by: Keith Packard <keithp at keithp.com> >> (Ported from xserver commit b91c787c4cd2d20685db69426c539938c556128a) >> Signed-off-by: Michel Dänzer <michel.daenzer at amd.com> > > Thanks for porting this and making it compile on older server versions; > I notice that you switched from xallocarray to calloc -- seems fine to > me as it avoids some extra configure.ac goop. Yep, didn't see the point of that, as ncrtc + noutput needs to be explicitly checked for overflow anyway. > For the series: > Reviewed-by: Keith Packard <keithp at keithp.com> Thanks! -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer
