[PATCH 0/3] drm/scheduler: preparation for load balancing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Only a few more style nit picks:

Patches #1 and #2 need a commit message. A one liner why we do this 
should be fine.

On Patch #3 you have a couple of places like this:
> -	r = drm_sched_entity_init(&ring->sched, &adev->mman.entity,
> -				  rq, NULL);
> +	r = drm_sched_entity_init(&adev->mman.entity,
> +				  &rq, 1, NULL);
If I'm not completely mistaken that could be written on one line now and 
still be shorter than 80 characters.

Those are not major issues, so patches are Reviewed-by: Christian König 
<christian.koenig at amd.com> either way.

If neither Lucas nor Eric object I'm going to pick them those patches up 
on Friday.

Thanks for the help,
Christian.

Am 12.07.2018 um 08:36 schrieb Nayan Deshmukh:
> This patch series is prepration for implementing better load balancing
> in the GPU scheduler. Patch #3 is the major change which modifies the
> drm_sched_entity_init, the driver is now expected to provide a list of
> potential run queue on which the jobs from this entity can be scheduled.
>
> In future patches we will add functionality to scheduler to select the
> run queue which has the least amount of load. To avoid making
> significant changes to multiple drivers in the same patch I am not yet
> sending a list to drm_sched_entity_init. I will make seprate patches for
> each driver for that.
>
> Regards,
> Nayan Deshmukh
>
> Nayan Deshmukh (3):
>    drm/scheduler: add a pointer to scheduler in the rq
>    drm/scheduler: add counter for total jobs in scheduler
>    drm/scheduler: modify args of drm_sched_entity_init
>
>   drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c   |  4 ++--
>   drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c   |  4 ++--
>   drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c   |  4 ++--
>   drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c   |  4 ++--
>   drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c    |  4 ++--
>   drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c     |  4 ++--
>   drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c     |  4 ++--
>   drivers/gpu/drm/etnaviv/etnaviv_drv.c     |  8 ++++----
>   drivers/gpu/drm/scheduler/gpu_scheduler.c | 31 +++++++++++++++++++++----------
>   drivers/gpu/drm/v3d/v3d_drv.c             |  7 +++----
>   include/drm/gpu_scheduler.h               | 17 +++++++++++++----
>   11 files changed, 55 insertions(+), 36 deletions(-)
>



[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux