[PATCH 3/3] drm/amdgpu: move cache window setup after power and clock resume

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Looks like the patches should be reordered, e.g. patch #2 should be the 
last.

Apart from that Reviewed-by: Christian König <christian.koenig at amd.com>.

Regards,
Christian.

Am 09.07.2018 um 18:54 schrieb Deucher, Alexander:
>
> Series is:
>
> Reviewed-by: Alex Deucher <alexander.deucher at amd.com>
>
> ------------------------------------------------------------------------
> *From:* amd-gfx <amd-gfx-bounces at lists.freedesktop.org> on behalf of 
> Leo Liu <leo.liu at amd.com>
> *Sent:* Monday, July 9, 2018 12:11:38 PM
> *To:* amd-gfx at lists.freedesktop.org
> *Cc:* Liu, Leo
> *Subject:* [PATCH 3/3] drm/amdgpu: move cache window setup after power 
> and clock resume
> To make register read/write reliable. Along with the previous patch,
> VCN will work with dpm disabled case.
>
> Signed-off-by: Leo Liu <leo.liu at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c 
> b/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c
> index b82c92084b6f..ca4265bc10b9 100644
> --- a/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c
> @@ -600,12 +600,12 @@ static int vcn_v1_0_start(struct amdgpu_device 
> *adev)
>          /* disable byte swapping */
>          lmi_swap_cntl = 0;
>
> -       vcn_v1_0_mc_resume(adev);
> -
>          vcn_1_0_disable_static_power_gating(adev);
>          /* disable clock gating */
>          vcn_v1_0_disable_clock_gating(adev);
>
> +       vcn_v1_0_mc_resume(adev);
> +
>          /* disable interupt */
>          WREG32_P(SOC15_REG_OFFSET(UVD, 0, mmUVD_MASTINT_EN), 0,
>                          ~UVD_MASTINT_EN__VCPU_EN_MASK);
> -- 
> 2.17.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
>
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20180710/560084f0/attachment.html>


[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux