Hi Evan, On 2018-06-20 08:40 AM, Evan Quan wrote: > On UVD/VCE dpm enabled/disabled, the powergate status will be > set as false/true. So that we will not try to ungate/gate them( > enable/disable their dpm) again. > > v2: added check for uvd/vce powergate status before gating > v3: fix typo in description > > Change-Id: I569a5aa216b5e7d64a2b504f2ff98cc83ca802d5 > Signed-off-by: Evan Quan <evan.quan at amd.com> This patch introduced the following warnings: CC [M] drivers/gpu/drm//amd/amdgpu/../powerplay/hwmgr/vega12_hwmgr.o drivers/gpu/drm//amd/amdgpu/../powerplay/hwmgr/vega12_hwmgr.c: In function â??vega12_power_gate_vceâ??: drivers/gpu/drm//amd/amdgpu/../powerplay/hwmgr/vega12_hwmgr.c:2006:10: warning: â??returnâ?? with a value, in function returning void return 0; ^ drivers/gpu/drm//amd/amdgpu/../powerplay/hwmgr/vega12_hwmgr.c:2001:13: note: declared here static void vega12_power_gate_vce(struct pp_hwmgr *hwmgr, bool bgate) ^~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm//amd/amdgpu/../powerplay/hwmgr/vega12_hwmgr.c: In function â??vega12_power_gate_uvdâ??: drivers/gpu/drm//amd/amdgpu/../powerplay/hwmgr/vega12_hwmgr.c:2017:10: warning: â??returnâ?? with a value, in function returning void return 0; ^ drivers/gpu/drm//amd/amdgpu/../powerplay/hwmgr/vega12_hwmgr.c:2012:13: note: declared here static void vega12_power_gate_uvd(struct pp_hwmgr *hwmgr, bool bgate) ^~~~~~~~~~~~~~~~~~~~~ -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer