I was going to say the same thing. I think it would be better to add it to the ppfeature mask for consistency. Alex ________________________________ From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> on behalf of Zhu, Rex <Rex.Zhu at amd.com> Sent: Tuesday, June 26, 2018 7:10:52 AM To: Michel Dänzer Cc: amd-gfx at lists.freedesktop.org Subject: Re: [PATCH 1/2] drm/amdgpu: Add module parameter stutter_mode Evev when enabled this feature by default,we still need a way to disable it easily for triage issue maybe related to stutter mode. as this feature is related to power saving. so we may add a bit mask in parameter ppfeaturemask. Best Regards Rex è?·å?? Outlook for Android<https://aka.ms/ghei36> ________________________________ From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> on behalf of Michel Dänzer <michel at daenzer.net> Sent: Tuesday, June 26, 2018 6:38:14 PM To: Zhu, Rex Cc: Zhu, Rex; amd-gfx at lists.freedesktop.org Subject: Re: [PATCH 1/2] drm/amdgpu: Add module parameter stutter_mode On 2018-06-26 12:23 PM, rex zhu wrote: > Add new parameter to control stutter mode enable/disable. > > Enable stutter mode can save power in low DRAM use cases > including but not limited to productivity application use, > web browsing, and video playback. We already have too many module parameters. Do we really need yet another one for this? Can't stutter mode just automatically be enabled when appropriate? -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer _______________________________________________ amd-gfx mailing list amd-gfx at lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx -------------- next part -------------- An HTML attachment was scrubbed... URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20180626/2690dea2/attachment.html>
