[PATCH] drm/amdgpu: GPU vs CPU page size fixes in amdgpu_vm_bo_split_mapping

ckoenig.leichtzumerken@xxxxxxxxx (Christian König) · Fri, 22 Jun 2018 16:57:50 +0200

Am 22.06.2018 um 16:12 schrieb Michel DÃ¤nzer:
> On 2018-06-22 12:34 PM, Christian KÃ¶nig wrote:
>> Am 22.06.2018 um 11:10 schrieb Michel DÃ¤nzer:
>>> From: Michel DÃ¤nzer <michel.daenzer at amd.com>
>>>
>>> start / last / max_entries are numbers of GPU pages, pfn / count are
>>> numbers of CPU pages. Convert between them accordingly.
>>>
>>> Fixes badness on systems with > 4K page size.
>>>
>>> Cc: stable at vger.kernel.org
>>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106258
>>> Reported-by: Matt Corallo <freedesktop at bluematt.me>
>>> Tested-by: foxbat at ruin.net
>>> Signed-off-by: Michel DÃ¤nzer <michel.daenzer at amd.com>
>> Nice work!
> Thanks.
>
>
>> Just one comment: Can we somewhere add a define for
>> "(PAGE_SIZE / AMDGPU_GPU_PAGE_SIZE)"?
>>
>> IIRC that term was used in the GART code as well and just adding it
>> somewhere could makes things cleaner if you ask me.
> Sure, but that can be a follow-up patch, right?
>
> Can I get your R-b for this one?

Certainly, patch is Reviewed-by: Christian KÃ¶nig <christian.koenig at amd.com>.

Thanks,
Christian.