Hi Alex, Just sent out a v2 version for this patch. On UVD/VCE dpm disabled, the powergate status will be set as true. So that we will not try to gate them(disable their dpm again). Regards, Evan > -----Original Message----- > From: Alex Deucher [mailto:alexdeucher at gmail.com] > Sent: Tuesday, June 19, 2018 11:10 PM > To: Quan, Evan <Evan.Quan at amd.com> > Cc: amd-gfx list <amd-gfx at lists.freedesktop.org> > Subject: Re: [PATCH 07/13] drm/amd/powerplay: initialize uvd/vce > powergate status > > On Tue, Jun 19, 2018 at 3:38 AM, Evan Quan <evan.quan at amd.com> wrote: > > On UVD/VCE dpm disabled, the powergate status should be set as true. > > Can you explain this patch a bit? Why is power gate state set to true when > dpm is disabled? > > Alex > > > > > Change-Id: I569a5aa216b5e7d64a2b504f2ff98cc83ca802d5 > > Signed-off-by: Evan Quan <evan.quan at amd.com> > > --- > > drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c | 17 > > +++++++++++++++++ > > 1 file changed, 17 insertions(+) > > > > diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c > > b/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c > > index a124b81..cb0589e 100644 > > --- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c > > +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c > > @@ -777,6 +777,21 @@ static int > vega12_set_allowed_featuresmask(struct pp_hwmgr *hwmgr) > > return 0; > > } > > > > +static void vega12_init_powergate_state(struct pp_hwmgr *hwmgr) { > > + struct vega12_hwmgr *data = > > + (struct vega12_hwmgr *)(hwmgr->backend); > > + > > + data->uvd_power_gated = true; > > + data->vce_power_gated = true; > > + > > + if (data->smu_features[GNLD_DPM_UVD].enabled) > > + data->uvd_power_gated = false; > > + > > + if (data->smu_features[GNLD_DPM_VCE].enabled) > > + data->vce_power_gated = false; } > > + > > static int vega12_enable_all_smu_features(struct pp_hwmgr *hwmgr) { > > struct vega12_hwmgr *data = > > @@ -801,6 +816,8 @@ static int vega12_enable_all_smu_features(struct > pp_hwmgr *hwmgr) > > } > > } > > > > + vega12_init_powergate_state(hwmgr); > > + > > return 0; > > } > > > > -- > > 2.7.4 > > > > _______________________________________________ > > amd-gfx mailing list > > amd-gfx at lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/amd-gfx
