On 2018-06-15 05:18 PM, Christian König wrote: > Am 15.06.2018 um 17:14 schrieb Michel Dänzer: >> On 2018-06-15 05:11 PM, Christian König wrote: >>> Am 15.06.2018 um 16:42 schrieb Michel Dänzer: > >>>> + >>>> +   if (mem->start >= adev->gmc.visible_vram_size >> PAGE_SHIFT) >>>>           return amdgpu_bo_size(bo); >>>>   -   return 0; >>>> +   if (!nodes) >>>> +       return 0; >>>> + >>>> +   spin_lock(&mgr->lock); >>> I actually don't see any need to grab the lock here. >> Ah, so amdgpu_vram_mgr_del only grabs it for drm_mm_remove_node? > > Yes, exactly. Will drop it in v2, thanks! -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer