There are multiple occasions of "adev->gmc.visible_vram_size < adev->gmc.real_vram_size" in amdgpu_cs.c. It's basically the same check as in amdgpu_vm_is_large_bar(). I suggest to name it something like amdgpu_gmc_vram_full_visible() or similar since the BAR actually doesn't needs to be large for that. Thanks, Christian. Am 12.06.2018 um 17:06 schrieb Andrey Grodzovsky: > I didn't find that check in amdgpu_cs.c, can you clarify please ? > > Andrey > > > On 06/12/2018 10:41 AM, Christian König wrote: >> >> Unrelated to this patch, but we should probably move that function >> into amdgpu_gmc.h. >> >> There are a couple of more occasions of that check waiting for >> cleanup in amdgpu_cs.c. >> >> Can you take care of cleaning that up as well? Thanks in advance. > > _______________________________________________ > amd-gfx mailing list > amd-gfx at lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx
