On 2018-05-31 12:30 PM, Michel Dänzer wrote: > On 2018-05-30 08:42 PM, Leo Liu wrote: >> There are four ioctls in this files, and DOC gives details of >> data structures for each of ioctls, and their functionalities. >> >> Signed-off-by: Leo Liu <leo.liu at amd.com> > > This isn't enough to actually make this part of the generated > documentation. It needs to be hooked up to a *.rst file for that. > > I'm adding an amdgpu.rst file in > https://patchwork.freedesktop.org/series/44035/ , where you could hook > it up accordingly. Michel, have you submitted this one? So we can hook up the files gradually. I do not see the patches in this list. Sam > > Please check that generating the documentation (e.g. with make htmldocs) > doesn't produce any warnings about amdgpu_cs.c, and that the result > looks good in Documentation/output/gpu/amdgpu.html . The documentation > format itself is documented in Documentation/output/doc-guide/index.html . > > [...]