Patches #1 - #8 and patches #11-#18 are Reviewed-by: Christian König
<christian.koenig at amd.com>.
Patch #9:
> static void vcn_v1_0_jpeg_ring_patch_wreg(struct amdgpu_ring *ring, uint32_t ptr, uint32_t reg_offset, uint32_t val)
That you don't pass ptr by reference here looks like a bug to me.
Patch #10:
> + .extra_dw = 0,
I think we should either drop that or add it to all the other rings as
well. I certainly prefer to just drop it, cause it's less maintenance work.
Apart from that the patch is Reviewed-by: Christian König
<christian.koenig at amd.com> as well.
Thanks,
Christian.
Am 30.05.2018 um 22:27 schrieb boyuan.zhang at amd.com:
> From: Boyuan Zhang <boyuan.zhang at amd.com>
>
> Add AMDGPU_RING_TYPE_VCN_JPEG ring define
>
> Signed-off-by: Boyuan Zhang <boyuan.zhang at amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h
> index 1513124c..a3908ef 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h
> @@ -53,7 +53,8 @@ enum amdgpu_ring_type {
> AMDGPU_RING_TYPE_KIQ,
> AMDGPU_RING_TYPE_UVD_ENC,
> AMDGPU_RING_TYPE_VCN_DEC,
> - AMDGPU_RING_TYPE_VCN_ENC
> + AMDGPU_RING_TYPE_VCN_ENC,
> + AMDGPU_RING_TYPE_VCN_JPEG
> };
>
> struct amdgpu_device;
