Looks good except a few comments.
On Mon, May 28, 2018 at 09:11:03AM +0800, Evan Quan wrote:
> Change-Id: I8dfafcce9e4ed6dabb7025a5a822d1135de6cb8a
Evan, Rex, we'd better add a description for the commit, because community
don't like the empty commit log for the patches. Actually, we got pinged by
Linus...
> Signed-off-by: Evan Quan <evan.quan at amd.com>
> ---
> drivers/gpu/drm/amd/include/atomfirmware.h | 15 +++++++--------
> 1 file changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/include/atomfirmware.h b/drivers/gpu/drm/amd/include/atomfirmware.h
> index 95e187e..f25a16b 100644
> --- a/drivers/gpu/drm/amd/include/atomfirmware.h
> +++ b/drivers/gpu/drm/amd/include/atomfirmware.h
> @@ -2112,17 +2112,16 @@ enum atom_smu11_syspll_id {
> SMU11_SYSPLL3_1_ID = 6,
> };
>
> -
> -enum atom_smu11_syspll0_clock_id {
> - SMU11_SYSPLL0_SOCCLK_ID = 0, // SOCCLK
> - SMU11_SYSPLL0_MP0CLK_ID = 1, // MP0CLK
> - SMU11_SYSPLL0_DCLK_ID = 2, // DCLK
> - SMU11_SYSPLL0_VCLK_ID = 3, // VCLK
> - SMU11_SYSPLL0_ECLK_ID = 4, // ECLK
> +enum atom_smu11_syspll0_clock_id
> +{
Open brace '{' following enum go on the same line.
With that fixed, please add
Reviewed-by: Huang Rui <ray.huang at amd.com>
> + SMU11_SYSPLL0_ECLK_ID = 0, // ECLK
> + SMU11_SYSPLL0_SOCCLK_ID = 1, // SOCCLK
> + SMU11_SYSPLL0_MP0CLK_ID = 2, // MP0CLK
> + SMU11_SYSPLL0_DCLK_ID = 3, // DCLK
> + SMU11_SYSPLL0_VCLK_ID = 4, // VCLK
> SMU11_SYSPLL0_DCEFCLK_ID = 5, // DCEFCLK
> };
>
> -
> enum atom_smu11_syspll1_0_clock_id {
> SMU11_SYSPLL1_0_UCLKA_ID = 0, // UCLK_a
> };
> --
> 2.7.4
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
