On 2018-05-28 08:00 PM, sunpeng.li at amd.com wrote: > From: "Leo (Sunpeng) Li" <sunpeng.li at amd.com> > > For cases where the CRTC is inactive (DPMS off), where a modeset is not > required, yet the CRTC is still in the atomic state, we should not > attempt to update anything on it. > > Previously, we were relying on the modereset_required() helper to check > the above condition. However, the function returns false immediately if > a modeset is not required, ignoring the CRTC's enable/active state > flags. The correct way to filter is by looking at these flags instead. > > Fixes: e277adc5a06c "drm/amd/display: Hookup color management functions" Might also want to add Bugzilla: https://bugs.freedesktop.org/106194 for good measure. > Signed-off-by: Leo (Sunpeng) Li <sunpeng.li at amd.com> > Reviewed-by: Harry Wentland <harry.wentland at amd.com> > Tested-by: Michel Dänzer <michel.daenzer at amd.com> > --- > > v2: Fix commit message typo (immediatly -> immediately) > Add Fixes line and Michel's Tested-by Other than that looks good, thanks! -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer
