On 2018-05-28 05:15 AM, Michel Dänzer wrote: > > Hi Leo, > > > commit e277adc5a06c "drm/amd/display: Hookup color management functions" > broke suspend to RAM on my development system with a Tonga and a Turks > (using the radeon driver). It sometimes, but not always happens when > trying to suspend from the GNOME login screen in Wayland mode (I first > noticed the problem when that started happening automatically after a > timeout). I can reproduce it reliably by logging into a GNOME on Wayland > session and suspending from there. > > The BUG_ON added by this commit triggers during suspend, see below. This > prevents the suspend (and later system shutdown as well) from > completing. > Thanks for the heads up. Can you give the patch on this ticket a try? https://bugs.freedesktop.org/show_bug.cgi?id=106194 Leo > > [ 783.704303] kernel BUG at drivers/gpu/drm//amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:4642! > [ 783.704317] invalid opcode: 0000 [#1] SMP NOPTI > [ 783.704321] Modules linked in: fuse lz4 lz4_compress cpufreq_powersave cpufreq_userspace cpufreq_conservative binfmt_misc sunrpc amdkfd(O) nls_ascii nls_cp437 vfat amdgpu(O) radeon(O) fat edac_mce_amd snd_hda_codec_realtek snd_hda_codec_generic kvm irqbypass chash(O) snd_hda_codec_hdmi crct10dif_pclmul gpu_sched(O) crc32_pclmul ttm(O) snd_hda_intel ghash_clmulni_intel wmi_bmof pcbc snd_hda_codec drm_kms_helper(O) snd_hda_core snd_hwdep aesni_intel aes_x86_64 crypto_simd glue_helper snd_pcm efi_pstore drm(O) i2c_algo_bit r8169 snd_timer k10temp fb_sys_fops cryptd mii pcspkr sg efivars syscopyarea sp5100_tco sysfillrect snd sysimgblt soundcore ccp i2c_piix4 rng_core wmi acpi_cpufreq button tcp_bbr sch_fq nct6775 hwmon_vid efivarfs ip_tables x_tables autofs4 ext4 crc32c_generic crc16 mbcache jbd2 fscrypto > [ 783.704423] dm_mod raid10 raid1 raid0 multipath linear md_mod sd_mod evdev hid_generic usbhid hid ahci xhci_pci libahci xhci_hcd libata crc32c_intel usbcore scsi_mod shpchp gpio_amdpt gpio_generic > [ 783.704458] CPU: 0 PID: 2009 Comm: gnome-shell Tainted: G W O 4.16.10+ #315 > [ 783.704461] Hardware name: Micro-Star International Co., Ltd. MS-7A34/B350 TOMAHAWK (MS-7A34), BIOS 1.80 09/13/2017 > [ 783.704542] RIP: 0010:dm_update_crtcs_state+0x3b8/0x440 [amdgpu] > [ 783.704546] RSP: 0018:ffffb53f884e7ad0 EFLAGS: 00010246 > [ 783.704552] RAX: 0000000000000000 RBX: ffff91c623f90000 RCX: 00000000000016cd > [ 783.704555] RDX: 00000000000016cc RSI: ffff91c62e626160 RDI: 0000000000026160 > [ 783.704559] RBP: ffff91c5bbd42000 R08: 0000000000000001 R09: 0000000000000000 > [ 783.704562] R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000 > [ 783.704566] R13: ffff91c62759b400 R14: ffff91c5b9d2c800 R15: ffff91c616212240 > [ 783.704570] FS: 00007f5032522ac0(0000) GS:ffff91c62e600000(0000) knlGS:0000000000000000 > [ 783.704574] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > [ 783.704578] CR2: 0000039936735a60 CR3: 00000003bbea2000 CR4: 00000000003406f0 > [ 783.704581] Call Trace: > [ 783.704661] amdgpu_dm_atomic_check+0x1b5/0x430 [amdgpu] > [ 783.704669] ? mark_held_locks+0x50/0x80 > [ 783.704675] ? find_held_lock+0x2d/0x90 > [ 783.704700] drm_atomic_check_only+0x370/0x570 [drm] > [ 783.704725] drm_atomic_commit+0x13/0x50 [drm] > [ 783.704746] drm_atomic_connector_commit_dpms+0xe5/0xf0 [drm] > [ 783.704767] set_property_atomic+0xb4/0x130 [drm] > [ 783.704793] drm_mode_obj_set_property_ioctl+0xf6/0x1b0 [drm] > [ 783.704813] ? drm_mode_obj_find_prop_id+0x40/0x40 [drm] > [ 783.704829] drm_ioctl_kernel+0x5b/0xb0 [drm] > [ 783.704848] drm_ioctl+0x2d8/0x390 [drm] > [ 783.704867] ? drm_mode_obj_find_prop_id+0x40/0x40 [drm] > [ 783.704875] ? __pm_runtime_resume+0x54/0x90 > [ 783.704882] ? trace_hardirqs_on_caller+0xed/0x180 > [ 783.704929] amdgpu_drm_ioctl+0x49/0x80 [amdgpu] > [ 783.704938] do_vfs_ioctl+0xa5/0x6e0 > [ 783.704946] ? __fget+0x105/0x1f0 > [ 783.704953] SyS_ioctl+0x74/0x80 > [ 783.704960] do_syscall_64+0x76/0x1b0 > [ 783.704967] entry_SYSCALL_64_after_hwframe+0x42/0xb7 > [ 783.704972] RIP: 0033:0x7f502f617f07 > [ 783.704976] RSP: 002b:00007ffeb81033d8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 > [ 783.704981] RAX: ffffffffffffffda RBX: 0000561ca2ab61e0 RCX: 00007f502f617f07 > [ 783.704984] RDX: 00007ffeb8103410 RSI: 00000000c01864ba RDI: 000000000000000b > [ 783.704987] RBP: 00007ffeb8103400 R08: 0000000000000003 R09: 0000000000000002 > [ 783.704990] R10: 0000561ca2ab0bc8 R11: 0000000000000246 R12: 00007ffeb8103410 > [ 783.704994] R13: 00000000c01864ba R14: 000000000000000b R15: 00007f503195ebb0 > [ 783.705002] Code: 44 24 18 c6 00 01 0f 85 bb fd ff ff e9 bf fd ff ff 41 0f b6 45 0a a8 0e 0f 84 25 fd ff ff 48 c7 04 24 00 00 00 00 e9 e5 fd ff ff <0f> 0b 48 83 bb e0 12 00 00 00 0f 84 f3 fe ff ff 48 83 3c 24 00 > [ 783.705152] RIP: dm_update_crtcs_state+0x3b8/0x440 [amdgpu] RSP: ffffb53f884e7ad0 > > >
