Looks like a good idea to me as well. Reviewed-by: Christian König <christian.koenig at amd.com> for the series. Regards, Christian. Am 11.05.2018 um 07:27 schrieb Zhou, David(ChunMing): > The series is OK to me, Reviewed-by: Chunming Zhou <david1.zhou at amd.com> > It is better to wait Christian to have a look before pushing patch. > > Regards, > David Zhou > -----Original Message----- > From: Junwei Zhang [mailto:Jerry.Zhang at amd.com] > Sent: Friday, May 11, 2018 12:58 PM > To: amd-gfx at lists.freedesktop.org; dri-devel at lists.freedesktop.org > Cc: Koenig, Christian <Christian.Koenig at amd.com>; Zhou, David(ChunMing) <David1.Zhou at amd.com>; Zhang, Jerry <Jerry.Zhang at amd.com> > Subject: [PATCH 2/2] drm/amdgpu: set ttm bo priority before initialization > > Signed-off-by: Junwei Zhang <Jerry.Zhang at amd.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c > index e62153a..6a9e46a 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c > @@ -419,6 +419,8 @@ static int amdgpu_bo_do_create(struct amdgpu_device *adev, > > bo->tbo.bdev = &adev->mman.bdev; > amdgpu_ttm_placement_from_domain(bo, bp->domain); > + if (bp->type == ttm_bo_type_kernel) > + bo->tbo.priority = 1; > > r = ttm_bo_init_reserved(&adev->mman.bdev, &bo->tbo, size, bp->type, > &bo->placement, page_align, &ctx, acc_size, @@ -434,9 +436,6 @@ static int amdgpu_bo_do_create(struct amdgpu_device *adev, > else > amdgpu_cs_report_moved_bytes(adev, ctx.bytes_moved, 0); > > - if (bp->type == ttm_bo_type_kernel) > - bo->tbo.priority = 1; > - > if (bp->flags & AMDGPU_GEM_CREATE_VRAM_CLEARED && > bo->tbo.mem.placement & TTM_PL_FLAG_VRAM) { > struct dma_fence *fence; > -- > 1.9.1 >
