On Mon, 7 May 2018 17:24:08 +0200
Daniel Vetter <daniel at ffwll.ch> wrote:
> On Mon, May 07, 2018 at 04:44:34PM +0200, Boris Brezillon wrote:
> > Now that the plane code takes the underscan setup into account, we can
> > safely attach the underscan props to the HDMI connector.
> >
> > We also take care of filling AVI infoframes correctly to expose the
> > top/botton/left/right bar.
> >
> > Note that these underscan props match pretty well the
> > overscan_{left,right,top,bottom} properties defined in config.txt and
> > parsed by the VC4 firmware.
> >
> > Signed-off-by: Boris Brezillon <boris.brezillon at bootlin.com>
> > ---
> > drivers/gpu/drm/vc4/vc4_hdmi.c | 25 +++++++++++++++++++++++++
> > 1 file changed, 25 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
> > index 1a6db291d48b..17464b5981f9 100644
> > --- a/drivers/gpu/drm/vc4/vc4_hdmi.c
> > +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
> > @@ -323,6 +323,16 @@ static struct drm_connector *vc4_hdmi_connector_init(struct drm_device *dev,
> > DRM_MODE_CONNECTOR_HDMIA);
> > drm_connector_helper_add(connector, &vc4_hdmi_connector_helper_funcs);
> >
> > + /* The hborder and vborder limit is arbitrarily set to 1024 which
> > + * should be more than enough for real use cases. Note that the actual
> > + * limitation comes from the display mode:
> > + * hborder < hdisplay && vborder < vdisplay
> > + */
> > + drm_connector_attach_underscan_properties(connector,
>
> We should probably sprinkle __must_check over all these :-)
I'm perfectly fine adding __must_check to
drm_connector_attach_underscan_properties(), but I'm definitely not
volunteering for a massive __must_check sanitization :P.
