Hi, On Mon, 7 May 2018 16:44:31 +0200 Boris Brezillon <boris.brezillon at bootlin.com> wrote: > Hello, > > This is an attempt at providing generic support for underscan connector > props. We already have 3 drivers defining the same underscan, underscan > vborder and underscan hborder properties (amd, radeon and nouveau) and > I am about to add a new one, hence my proposal to put the prop parsing > code in the core and add ->underscan fields to drm_connector_state. > > Note that I use this new infrastructure to support underscan in VC4 > (path 2 and 3) but did not patch existing drivers yet, mainly because I > don't want to do this work before making sure I got the generic bits > right. Thanks everyone for your reviews. After the discussion we had on IRC and the feedback I had on this patchset it's a bit unclear to me what the next iteration should look like. Should I continue with the underscan props, should I use TV margins exposed by the TV connector state, should I create new props? Remember that all I need is a way to define margins in order to let the VC4 HW scaler shrink the planes and adjust their positions on the screen. Thanks, Boris