On 2018-05-01 04:22 PM, Oded Gabbay wrote: > I believe it should be : > SPDX-License-Identifier: GPL-2.0 OR MIT > > But John probably knows best about this > Oded > > On Tue, May 1, 2018 at 11:14 PM, Felix Kuehling <felix.kuehling at amd.com> wrote: >> Hi, >> >> I'm getting a checkpatch warning with the latest amdkfd-next branch >> (4.17-rc2) when adding a new file: >> >> WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 >> #34: FILE: drivers/gpu/drm/amd/amdkfd/cwsr_trap_handler.h:1: >> >> I've read Documentation/process/license-rules.rst but I'm unsure what >> would be the correct license identifier to go with the license header we >> use in most of our source files. I think it would be one of these: >> >> // SPDX-License-Identifier: GPL-2.0 OR MIT >> // SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause FWIW Intel uses MIT only: SPDX-License-Identifier: MIT See drivers/gpu/drm/i915/i915_query.c and a couple other i915 files. Harry >> >> Can someone confirm. >> >> Once that's clarified, we should probably add the appropriate license >> identifier to all our source files. >> >> Thanks, >> Felix >> >> -- >> F e l i x K u e h l i n g >> PMTS Software Development Engineer | Vertical Workstation/Compute >> 1 Commerce Valley Dr. East, Markham, ON L3T 7X6 Canada >> (O) +1(289)695-1597 >> _ _ _ _____ _____ >> / \ | \ / | | _ \ \ _ | >> / A \ | \M/ | | |D) ) /|_| | >> /_/ \_\ |_| |_| |_____/ |__/ \| facebook.com/AMD | amd.com >> > _______________________________________________ > amd-gfx mailing list > amd-gfx at lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx >
