On 10 April 2018 at 10:27, Michel Dänzer <michel at daenzer.net> wrote: > On 2018-04-10 11:20 AM, Emil Velikov wrote: >> On 10 April 2018 at 09:26, Michel Dänzer <michel at daenzer.net> wrote: >>> On 2018-04-04 04:29 PM, Emil Velikov wrote: >>>> From: Emil Velikov <emil.velikov at collabora.com> >>>> >>>> The former of these is a UMS artefact which gives incorrect and >>>> misleading promise whether "KMS" is supported. Not to mention that >>>> AMDGPU is a only KMS driver. >>>> >>>> In a similar fashion xf86LoadKernelModule() is a relic of the times, >>>> where platforms had no scheme of detecting and loading the appropriate >>>> kernel module. >>>> >>>> Cc: Robert Millan <rmh at freebsd.org> >>>> Signed-off-by: Emil Velikov <emil.velikov at collabora.com> >>>> --- >>>> Robert, off the top of my head this should work with FreeBSD. Admittedly >>>> I'm not an expert on the platform. Please give it a test. >>> >>> I want to get confirmation from Robert that this will work on FreeBSD >>> now, since he explicitly restored the kernel module loading code in >>> https://cgit.freedesktop.org/xorg/driver/xf86-video-ati/commit/?id=bfbff3b246db509c820df17b8fcf5899882ffcfa >>> . >>> >> Fully agreed!. That's why I added him to the CC list. >> >> Throwing some ideas: >> - If it's still needed can we keep it !Linux only? > > The first drmCheckModesettingSupported call? Fine with me. > Since ifndef out the drmCheckModesettingSupported call makes amdgpu_kernel_mode_enabled function a no-op, I was thinking about ifndef the whole thing. Yet again, it would be so much better to actually nuke it (if possible). Robert, does one still need xf86LoadKernelModule and/or drmCheckModesettingSupported for FreeBSD? Thanks Emil
