On 2018-04-19 04:38 PM, Harry Wentland wrote: > On 2018-04-19 03:43 AM, Michel Dänzer wrote: >> On 2018-04-18 10:26 PM, Harry Wentland wrote: >>> The below commit >>> >>> "drm/atomic: Try to preserve the crtc enabled state in drm_atomic_remove_fb, v2" >>> >>> introduces a slight behavioral change to rmfb. Instead of disabling a crtc >>> when the primary plane is disabled, it now preserves it. >>> >>> Since DC is currently not equipped to handle this we need to fail such >>> a commit, otherwise we might see a corrupted screen. >> >> How does the caller react to failing such a commit? > > The caller (drm_atomic_remove_fb in this case) will retry with the old behavior and disable the CRTC. I see, thanks. FWIW, stopping gdm3 works fine with this patch as well. Tested-by: Michel Dänzer <michel.daenzer at amd.com> -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer
