Reviewed-by: Evan Quan <evan.quan at amd.com> > -----Original Message----- > From: amd-gfx [mailto:amd-gfx-bounces at lists.freedesktop.org] On Behalf > Of Rex Zhu > Sent: Thursday, April 19, 2018 12:48 PM > To: amd-gfx at lists.freedesktop.org > Cc: Zhu, Rex <Rex.Zhu at amd.com> > Subject: [PATCH] drm/amd/pp: Fix NULL point check error in > smu_set_watermarks_for_clocks_ranges > > It is caused by > 'commit d6c9a7dc86cd ("drm/amd/pp: Move common code to > smu_helper.c")' > > Signed-off-by: Rex Zhu <Rex.Zhu at amd.com> > --- > drivers/gpu/drm/amd/powerplay/hwmgr/smu_helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu_helper.c > b/drivers/gpu/drm/amd/powerplay/hwmgr/smu_helper.c > index 7c23741..93a3d02 100644 > --- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu_helper.c > +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu_helper.c > @@ -657,7 +657,7 @@ int smu_set_watermarks_for_clocks_ranges(void > *wt_table, > uint32_t i; > struct watermarks *table = wt_table; > > - if (!table || wm_with_clock_ranges) > + if (!table || !wm_with_clock_ranges) > return -EINVAL; > > if (wm_with_clock_ranges->num_wm_sets_dmif > 4 || > wm_with_clock_ranges->num_wm_sets_mcif > 4) > -- > 1.9.1 > > _______________________________________________ > amd-gfx mailing list > amd-gfx at lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx
