答复: [PATCH] sync amdgpu scanout update event before mode setting

Jim.Qu@xxxxxxx (Qu, Jim) · Wed, 18 Apr 2018 02:22:39 +0000

Hi,

Any comments for this patch?

Thanks
JimQu

________________________________________
å??ä»¶äºº: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> ä»£è¡¨ Jim Qu <Jim.Qu at amd.com>
å??é??æ?¶é?´: 2018å¹´4æ??17æ?¥ 19:11
æ?¶ä»¶äºº: amd-gfx at lists.freedesktop.org
æ??é??: Qu, Jim
ä¸»é¢?: [PATCH] sync amdgpu scanout update event before mode setting

There is a case that when set screen from reverse to normal, the old
scanout damage is freed in modesetting before sanout update handler,
so it causes segment fault issue.

Change-Id: I0fc6282688054d1e0f23d1ba66d4227553de53f3
Signed-off-by: Jim Qu <Jim.Qu at amd.com>
---
 src/drmmode_display.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/drmmode_display.c b/src/drmmode_display.c
index 85970d1..ea38e29 100644
--- a/src/drmmode_display.c
+++ b/src/drmmode_display.c
@@ -902,6 +902,9 @@ drmmode_set_mode_major(xf86CrtcPtr crtc, DisplayModePtr mode,
                drmmode_crtc_wait_pending_event(drmmode_crtc, pAMDGPUEnt->fd,
                                                drmmode_crtc->flip_pending);

+               drmmode_crtc_wait_pending_event(drmmode_crtc, pAMDGPUEnt->fd,
+                                               drmmode_crtc->scanout_update_pending);
+
                if (!drmmode_set_mode(crtc, fb, mode, x, y))
                        goto done;

--
1.9.1

_______________________________________________
amd-gfx mailing list
amd-gfx at lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx





