On 2018-04-09 11:03 AM, Michel Dänzer wrote: > On 2018-03-26 10:00 PM, sunpeng.li at amd.com wrote: >> From: "Leo (Sunpeng) Li" <sunpeng.li at amd.com> >> >> The functions insert into the output resource creation, and property >> change functions. CRTC destroy is also hooked-up for proper cleanup of >> the CRTC property list. >> >> Signed-off-by: Leo (Sunpeng) Li <sunpeng.li at amd.com> > > [...] > >> @@ -1933,6 +1933,9 @@ static void drmmode_output_create_resources(xf86OutputPtr output) >> } >> } >> } >> + >> + if (output->crtc) >> + drmmode_crtc_create_resources(output->crtc, output); > > output->crtc is only non-NULL here for outputs which are enabled at Xorg > startup; other outputs won't have the new properties. Is it necessary to have the CRTC properties on a output if the CRTC is disabled for that output? I've tested hot-plugging with this, and the properties do initialize on hot-plug. Though they stay on the output on hot-unplug... Haven't dug into this just yet. Leo > >