On 2018-04-04 11:17 AM, Deucher, Alexander wrote:
> Do other DCE blocks need this fix as well? Or is this code shared with
> say DCE8 and DCE10?
Yes, it's all shared. The hook for this is initialized in
dce110_hw_sequencer_construct(), which is called for all DCE.
Leo
>
>
> Alex
>
> ------------------------------------------------------------------------
> *From:* amd-gfx <amd-gfx-bounces at lists.freedesktop.org> on behalf of
> Harry Wentland <harry.wentland at amd.com>
> *Sent:* Tuesday, April 3, 2018 9:27 PM
> *To:* amd-gfx at lists.freedesktop.org
> *Cc:* Li, Sun peng (Leo)
> *Subject:* [PATCH 32/32] drm/amd/display: Fix dim display on DCE11
> From: "Leo (Sunpeng) Li" <sunpeng.li at amd.com>
>
> Before programming the input gamma, check that we're not using the
> identity correction.
>
> Signed-off-by: Leo (Sunpeng) Li <sunpeng.li at amd.com>
> Reviewed-by: Anthony Koo <Anthony.Koo at amd.com>
> Acked-by: Harry Wentland <harry.wentland at amd.com>
> ---
> Â drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 4 +++-
> Â 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> index 99d192200797..f385b18d5c2e 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> @@ -280,7 +280,9 @@ dce110_set_input_transfer_func(struct pipe_ctx
> *pipe_ctx,
> Â Â Â Â Â Â Â Â build_prescale_params(&prescale_params, plane_state);
> Â Â Â Â Â Â Â Â ipp->funcs->ipp_program_prescale(ipp, &prescale_params);
>
> -Â Â Â Â Â Â if (plane_state->gamma_correction &&
> dce_use_lut(plane_state->format))
> +Â Â Â Â Â Â if (plane_state->gamma_correction &&
> +Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â !plane_state->gamma_correction->is_identity &&
> +Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â dce_use_lut(plane_state->format))
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â ipp->funcs->ipp_program_input_lut(ipp,
> plane_state->gamma_correction);
>
> Â Â Â Â Â Â Â Â if (tf == NULL) {
> --
> 2.15.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
