when PPSMC_MSG_PmStatusLogSample sent, firmware will clean the temp sampling date, and add the sample task to dpm loop. but firmware not clean the registers. if firmware not update the registers, we will read out the original value. Best Regards Rex ________________________________ From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> on behalf of Eric Huang <jinhuieric.huang at amd.com> Sent: Friday, March 30, 2018 11:22 PM To: amd-gfx at lists.freedesktop.org Subject: Re: [PATCH] drm/amd/pp: Clean register first to avoid read original value On 03/30/2018 10:36 AM, Eric Huang wrote: > It is not necessary to do that. The register will reset to 0 after > reading. The register is not reset after reading. Actually after PPSMC_MSG_PmStatusLogSample sent, the register will be updated. So it is still not necessary to do that. Eric > > Eric > > > On 03/30/2018 03:33 AM, Rex Zhu wrote: >> Signed-off-by: Rex Zhu <Rex.Zhu at amd.com> >> --- >> drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) >> >> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c >> b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c >> index aaa9f5b..38cf3a1 100644 >> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c >> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c >> @@ -3368,6 +3368,19 @@ static int smu7_get_gpu_power(struct pp_hwmgr >> *hwmgr, >> "Failed to start pm status log!", >> return -1); >> + cgs_write_ind_register(hwmgr->device, >> + CGS_IND_REG__SMC, >> + ixSMU_PM_STATUS_40, 0); >> + cgs_write_ind_register(hwmgr->device, >> + CGS_IND_REG__SMC, >> + ixSMU_PM_STATUS_49, 0); >> + cgs_write_ind_register(hwmgr->device, >> + CGS_IND_REG__SMC, >> + ixSMU_PM_STATUS_94, 0); >> + cgs_write_ind_register(hwmgr->device, >> + CGS_IND_REG__SMC, >> + ixSMU_PM_STATUS_95, 0); >> + >> /* Sampling period from 50ms to 4sec */ >> msleep_interruptible(200); > _______________________________________________ amd-gfx mailing list amd-gfx at lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx amd-gfx Info Page - freedesktop.org<https://lists.freedesktop.org/mailman/listinfo/amd-gfx> lists.freedesktop.org Subscribing to amd-gfx: Subscribe to amd-gfx by filling out the following form. Use of all freedesktop.org lists is subject to our Code of Conduct. -------------- next part -------------- An HTML attachment was scrubbed... URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20180331/bb92e39d/attachment.html>
