On Mon, Mar 26, 2018 at 12:47:01PM +0200, Christian König wrote: > Am 26.03.2018 um 10:36 schrieb Daniel Vetter: > > On Sun, Mar 25, 2018 at 01:34:51PM +0200, Christian König wrote: > [SNIP] > > > - attach->dev = dev; > > > + attach->dev = info->dev; > > > attach->dmabuf = dmabuf; > > > + attach->priv = info->priv; > > The ->priv field is for the exporter, not the importer. See e.g. > > drm_gem_map_attach. You can't let the importer set this now too, so needs > > to be removed from the info struct. > > Crap, in this case I need to add an importer_priv field because we now need > to map from the attachment to it's importer object as well. > > Thanks for noticing this. Maybe add the importer_priv field only in the series that actually adds it, not in this prep patch. You can mention all the fields you need here in the commit message for justification. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
