Please donâ??t do it for SR-IOV /Monk From: amd-gfx [mailto:amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx] On Behalf Of Quan, Evan Sent: 2018å¹´3æ??19æ?¥ 9:47 To: Deucher, Alexander <Alexander.Deucher at amd.com>; Michel Dänzer <michel at daenzer.net> Cc: amd-gfx at lists.freedesktop.org Subject: RE: [PATCH] drm/amdgpu: no job timeout setting on compute queues Thatâ??s fine for me. Will update the patch accordingly. Regards, Evan From: Deucher, Alexander Sent: Saturday, March 17, 2018 1:17 AM To: Michel Dänzer <michel at daenzer.net<mailto:michel at daenzer.net>>; Quan, Evan <Evan.Quan at amd.com<mailto:Evan.Quan at amd.com>> Cc: amd-gfx at lists.freedesktop.org<mailto:amd-gfx at lists.freedesktop.org> Subject: Re: [PATCH] drm/amdgpu: no job timeout setting on compute queues How about something like this: /* Disable timeout when GPU reset is disabled to avoid confusing timeout messages in the kernel log */ If (amdgpu_gpu_recovery == 0 || amdgpu_gpu_recovery == -1) amdgpu_lockup_timeout = MAX_SCHEDULE_TIMEOUT; Alex ________________________________ From: Michel Dänzer <michel@xxxxxxxxxxx<mailto:michel at daenzer.net>> Sent: Friday, March 16, 2018 12:25:03 PM To: Deucher, Alexander; Quan, Evan Cc: amd-gfx at lists.freedesktop.org<mailto:amd-gfx at lists.freedesktop.org> Subject: Re: [PATCH] drm/amdgpu: no job timeout setting on compute queues On 2018-03-16 05:14 PM, Deucher, Alexander wrote: > Since GPU reset is not enabled yet anyway, a timeout will just print a > message, can we just change amdgpu_lockup_timeout to > MAX_SCHEDULE_TIMEOUT until we enable GPU reset? Wouldn't that be rather surprising for somebody who sets amdgpu.gpu_recovery=1 ? -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer -------------- next part -------------- An HTML attachment was scrubbed... URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20180326/687e8d79/attachment.html>
