>For patch 4, I think we should stick with the asic names. The smu7 variants are too confusing. I can't remember if CI was 7.0.1 or 7.0.2, etc. I'd prefer to align the file names to the >smu interface headers (e.g., smu7, smu71, smu72, smu73, smu74). Rex: For patch4, I am ok with the asic names for smu7. So I will drop this patch. >BTW, did you use git mv to generate these patches? Rex: No, I just rename the file name and git add -A, then the git status show file rename. Best Regards Rex -----Original Message----- From: Alex Deucher [mailto:alexdeucher@xxxxxxxxx] Sent: Wednesday, March 07, 2018 12:42 AM To: Zhu, Rex Cc: amd-gfx list Subject: Re: [PATCH 1/4] drm/amd/pp: Replace files name rv_* with smu10_* On Tue, Mar 6, 2018 at 5:10 AM, Rex Zhu <Rex.Zhu at amd.com> wrote: > Powerplay is for the hw ip smu, for RV, smu10 is used, so use smu10 as > the prefix of the files name. > > Change-Id: Icf9c8a9d4b5deccd4fbfb9ecfab443db79934c77 > Signed-off-by: Rex Zhu <Rex.Zhu at amd.com> > --- > drivers/gpu/drm/amd/powerplay/hwmgr/Makefile | 2 +- > drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c | 1075 ------------------- > drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.h | 322 ------ > drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c | 1076 > ++++++++++++++++++++ drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.h | 322 ++++++ > drivers/gpu/drm/amd/powerplay/smumgr/Makefile | 2 +- > drivers/gpu/drm/amd/powerplay/smumgr/rv_smumgr.c | 399 -------- > drivers/gpu/drm/amd/powerplay/smumgr/rv_smumgr.h | 61 -- > .../gpu/drm/amd/powerplay/smumgr/smu10_smumgr.c | 399 ++++++++ > .../gpu/drm/amd/powerplay/smumgr/smu10_smumgr.h | 61 ++ > 10 files changed, 1860 insertions(+), 1859 deletions(-) delete mode > 100644 drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c > delete mode 100644 drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.h > create mode 100644 drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c > create mode 100644 drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.h > delete mode 100644 drivers/gpu/drm/amd/powerplay/smumgr/rv_smumgr.c > delete mode 100644 drivers/gpu/drm/amd/powerplay/smumgr/rv_smumgr.h > create mode 100644 > drivers/gpu/drm/amd/powerplay/smumgr/smu10_smumgr.c > create mode 100644 > drivers/gpu/drm/amd/powerplay/smumgr/smu10_smumgr.h I'm ok with patches 1-3, although I think we should work on renaming the functions eventually too to match the file names. For patch 4, I think we should stick with the asic names. The smu7 variants are too confusing. I can't remember if CI was 7.0.1 or 7.0.2, etc. I'd prefer to align the file names to the smu interface headers (e.g., smu7, smu71, smu72, smu73, smu74). BTW, did you use git mv to generate these patches? Alex
