Am 06.03.2018 um 10:15 schrieb Daniel Vetter: > On Wed, Feb 28, 2018 at 11:25:59AM +0100, Christian König wrote: >> Am 28.02.2018 um 10:48 schrieb Lucas Stach: >>> Hi Christian, >>> >>> Am Dienstag, den 27.02.2018, 12:49 +0100 schrieb Christian König: >>>> Unpin the GEM object only after freeing the sg table. >>> What is the race that is being fixed here? The SG table is private to >>> the importer and the importer should hopefully only call map_detach if >>> it is done with all operations using the SG table. Thus it shouldn't >>> matter that the SG table might point to moved pages during execution of >>> this function. >> Exactly, it shouldn't matter. This is just a precaution. >> >> When the device driver is buggy I want proper error messages from IOMMU and >> not accessing pages which might already be reused for something else. > Please add this to the commit message, rather crucial to understand the > motivation. With that fixed you can have my > > Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch> > > And pls push to drm-misc. Can I use standard git for that now? I really don't want to mess with dim in my environment. Christian.
