Good. I will follow in new power profile implementation.
Best Regards
Rex
________________________________
From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> on behalf of Felix Kuehling <felix.kuehling at amd.com>
Sent: Wednesday, February 28, 2018 5:01 AM
To: amd-gfx at lists.freedesktop.org
Subject: Re: [PATCH] drm/amd/powerplay: fix power over limit on Fiji
Reviewed-by: Felix Kuehling <Felix.Kuehling at amd.com>
On 2018-02-27 03:57 PM, Eric Huang wrote:
> power containment disabled only on Fiji and compute
> power profile. It violates PCIe spec and may cause power
> supply failed. Enabling it will fix the issue, even the
> fix will drop performance of some compute tests.
>
> Signed-off-by: Eric Huang <JinHuiEric.Huang at amd.com>
> ---
> drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
> index 535d786..731475b 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
> @@ -4630,13 +4630,6 @@ static int smu7_set_power_profile_state(struct pp_hwmgr *hwmgr,
> int tmp_result, result = 0;
> uint32_t sclk_mask = 0, mclk_mask = 0;
>
> - if (hwmgr->chip_id == CHIP_FIJI) {
> - if (request->type == AMD_PP_GFX_PROFILE)
> - smu7_enable_power_containment(hwmgr);
> - else if (request->type == AMD_PP_COMPUTE_PROFILE)
> - smu7_disable_power_containment(hwmgr);
> - }
> -
> if (hwmgr->dpm_level != AMD_DPM_FORCED_LEVEL_AUTO)
> return -EINVAL;
>
_______________________________________________
amd-gfx mailing list
amd-gfx at lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
amd-gfx Info Page - freedesktop.org<https://lists.freedesktop.org/mailman/listinfo/amd-gfx>
lists.freedesktop.org
Subscribing to amd-gfx: Subscribe to amd-gfx by filling out the following form. Use of all freedesktop.org lists is subject to our Code of ...
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20180227/f9a7ff29/attachment.html>
