The cause is found: In amdgpu_pci_probe(), we set support_atomic to true no matter sriov or BM, because "adev" is not created yet so cannot judge SRIOV or not that time ... But in amdgpu_fbdev_init(), we check if need to call that disable_unused_function() by amdgpu_device_has_dc_support() which would return false For SRIOV case, That way we have two result checking DC support in amdgpu_pci_probe() and amdgpu_fbdev_init(), and lead to this error reporting. -----Original Message----- From: Michel Dänzer [mailto:michel@xxxxxxxxxxx] Sent: 2018å¹´2æ??27æ?¥ 17:38 To: Liu, Monk <Monk.Liu at amd.com> Cc: amd-gfx at lists.freedesktop.org Subject: Re: [PATCH 3/6] drm/amdgpu: should call drm_helper with dc support On 2018-02-27 10:26 AM, Liu, Monk wrote: > I'm not familiar with DC stuffs, I found without this patch DRM always reporting error like this: [...] > [ 89.936514] [drm:drm_helper_disable_unused_functions [drm_kms_helper]] *ERROR* Called for atomic driver, this is not what you want. "atomic driver" means DC is enabled, in which case drm_helper_disable_unused_functions shouldn't have been called. Maybe the issue is that DRIVER_ATOMIC is a driver flag, whereas DC can be enabled or not per device. See the discussion on https://patchwork.freedesktop.org/patch/200304/ . Meanwhile, NAK for this patch. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer
