On 2018-02-26 04:26 PM, Alex Deucher wrote:
> On Mon, Feb 26, 2018 at 3:15 PM, Harry Wentland <harry.wentland at amd.com> wrote:
>> From: Shirish S <shirish.s at amd.com>
>>
>> Currently the FBC buffer is allocated in VRAM, since VRAM usage is
>> dedicatedly for scanouts, by allocating FBC back buffer in GTT
>> shall help in conserving VRAM for other purposes.
>
> Are there any dGPUs that support FBC? If so, will this be an issue there?
>
We only create dc->fbc_compressor for DCE11 (CZ/ST) so amdgpu_dm_fbc_init will early return.
See dce110_resource.c's construct()
Harry
> Alex
>
>>
>> Signed-off-by: Shirish S <shirish.s at amd.com>
>> Reviewed-by: Charlene Liu <Charlene.Liu at amd.com>
>> Acked-by: Harry Wentland <harry.wentland at amd.com>
>> ---
>> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> index f782518fc424..64a3abed2466 100644
>> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> @@ -374,7 +374,7 @@ static void amdgpu_dm_fbc_init(struct drm_connector *connector)
>>
>> if (max_size) {
>> int r = amdgpu_bo_create_kernel(adev, max_size * 4, PAGE_SIZE,
>> - AMDGPU_GEM_DOMAIN_VRAM, &compressor->bo_ptr,
>> + AMDGPU_GEM_DOMAIN_GTT, &compressor->bo_ptr,
>> &compressor->gpu_addr, &compressor->cpu_addr);
>>
>> if (r)
>> --
>> 2.14.1
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
