> To avoid conflicts and confusion, I think better remove two old sysfs. Well that is not a matter of personal opinion. The rule is simply that sysfs needs to be stable, otherwise we can't upstream a sysfs interface. Especially since you already noted that current ROCM tool and KFD depend on them. What we can argue is that if this never worked on Vega10 we can remove it for Vega10 but keep it for older ASICs. Alternative we can have some sort of compatibility code which translates the old interface into the new one, e.g. in this case I think a simple symlink should do. Regards, Christian. Am 26.02.2018 um 03:54 schrieb Zhu, Rex: > We have added new sysfs pp_power_profile_mode. > > The old sysfs (pp_compute_power_profile and pp_gfx_power_profile) > were used internally currently by ROCM tool and KFD to switch mode between gfx and compute only on VI/CI asics. > We can't extend more modes for other workloads, for example: video, power saving mode,etc. > And the old sysfs can't support VEGA. > > With new sysfs, User can switch mode based on workloads(video, power save, gfx, compute, VR), or configure custom mode. > > To avoid conflicts and confusion, I think better remove two old sysfs. > > > Best Regards > Rex > -----Original Message----- > From: Christian König [mailto:ckoenig.leichtzumerken at gmail.com] > Sent: Sunday, February 25, 2018 9:19 PM > To: Zhu, Rex; amd-gfx at lists.freedesktop.org > Subject: Re: [PATCH 01/10] drm/amdgpu: bump version for new power profile sysfs > > Am 24.02.2018 um 14:55 schrieb Rex Zhu: >> Add new power profile sysfs: pp_power_profile_mode old sysfs: >> pp_compute_power_profile/pp_gfx_power_profile >> will be removed > Well sysfs is supposed to be stable, so removing the old interface won't be allowed. > >> Change-Id: Ief35efb81b313115b33c430dfb328ad83ce7975d >> Signed-off-by: Rex Zhu <Rex.Zhu at amd.com> >> --- >> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c >> b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c >> index 69cf490..4c92239 100644 >> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c >> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c >> @@ -75,6 +75,7 @@ >> * - 3.23.0 - Add query for VRAM lost counter >> * - 3.24.0 - Add high priority compute support for gfx9 >> * - 3.25.0 - Add support for sensor query info (stable pstate sclk/mclk). >> + * - 3.26.0 - Delete old gfx/compute profile sysfs, add common profile sysfs. >> */ >> #define KMS_DRIVER_MAJOR 3 >> #define KMS_DRIVER_MINOR 25 > Well you actually also need to bump the version, e.g. modify KMS_DRIVER_MINOR. > > Christian.
